Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spec): Add Manifest List #17

Merged
merged 6 commits into from
Aug 2, 2024

Conversation

Asura7969
Copy link
Contributor

@Asura7969 Asura7969 commented Jul 9, 2024

close #14
This PR will add Manifest List.

crates/paimon/src/spec/manifest_file_meta.rs Show resolved Hide resolved
crates/paimon/src/spec/manifest_file_meta.rs Outdated Show resolved Hide resolved
crates/paimon/src/spec/manifest_file_meta.rs Outdated Show resolved Hide resolved
crates/paimon/src/spec/manifest_list.rs Outdated Show resolved Hide resolved
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. It looks good to me overall.

crates/paimon/src/spec/manifest_file_meta.rs Outdated Show resolved Hide resolved
crates/paimon/src/spec/manifest_list.rs Outdated Show resolved Hide resolved
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo
Copy link
Member

Xuanwo commented Jul 18, 2024

cc @JingsongLi and @SteNicholas for another look.

@JingsongLi
Copy link
Contributor

Hi @Asura7969 , can you rebase and resolve conflicts.

@Asura7969
Copy link
Contributor Author

Hi @Asura7969 , can you rebase and resolve conflicts.

done

@SteNicholas
Copy link
Member

SteNicholas commented Jul 30, 2024

@Asura7969, rebase main branch and resolve the conflicts. Meanwhile, you could refer to f8c156f for updating the code link of reference.

@Asura7969
Copy link
Contributor Author

@SteNicholas done

@Xuanwo
Copy link
Member

Xuanwo commented Aug 1, 2024

Hi, @SteNicholas, I believe this PR is happy to go.

@SteNicholas SteNicholas merged commit a5cfac7 into apache:main Aug 2, 2024
7 checks passed
devillove084 pushed a commit to devillove084/paimon-rust that referenced this pull request Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spec: Implement Manifest List
5 participants